Right, if a phiCopySrc is a phi value and has been used as phiCopySrc for more than 1 phi values, current implementation will only try to optimize one of them. I will add a FIXME tag there, and will fix it in the future. As there are too many patches pending. To avoid unecessary conflicts. I prefer only fix those problems which related to correctness in this round. And defer the refinement part to the future patches.
Thanks, Zhigang Gong. On Tue, Sep 22, 2015 at 03:54:50AM +0000, Song, Ruiling wrote: > I just think of another optimization opportunity that may be missed in your > algorithm. > As you use a map<phiCopySrc, phiCopy> to record the possible to-be-coaleased > pair. > The phiCopySrc may be used in another phiNode in the same way. > Which the algorithm would not record. We may do it later. > Could you inline related comment into the patch? > Then others could easily understand the code. > Anyway, the patchset looks good. > > Thanks! > Ruiling > _______________________________________________ > Beignet mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/beignet _______________________________________________ Beignet mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/beignet
