Right if the phiCopySrc is not only a phi value but also be used as another phi value's phiCopySrc, then we will ignore it currently. I will put comments to describe this case.
Thanks, Zhigang Gong. > -----Original Message----- > From: Song, Ruiling > Sent: Tuesday, September 22, 2015 11:55 AM > To: Zhigang Gong > Cc: Gong, Zhigang; [email protected] > Subject: RE: [Beignet] [PATCH 5/5] GBE: implement further phi mov > optimization based on intra-BB interefering analysis. > > I just think of another optimization opportunity that may be missed in your > algorithm. > As you use a map<phiCopySrc, phiCopy> to record the possible to-be-coaleased > pair. > The phiCopySrc may be used in another phiNode in the same way. > Which the algorithm would not record. We may do it later. > Could you inline related comment into the patch? > Then others could easily understand the code. > Anyway, the patchset looks good. > > Thanks! > Ruiling _______________________________________________ Beignet mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/beignet
