On Tuesday 08 November 2011, Peter Rosin wrote:
> Peter Rosin skrev 2011-11-08 21:48:
>
> > msvc-for-1.11 seems to work ok here. Testsuite still running though.
>
> And it stumbled on extra-portability2.test for similar reasons as
> with ar-lib{3,4}.test but I'm not sure if the "sanity check" should
> just be removed or what?
>
> The "sanity check" is:
>
> # Make sure the test is useful.
> AUTOMAKE_fails
>
> but this doesn't fail since extra-portability isn't activated by -Wall.
>
The point of the sanity check is to ensure that the test case setup really
causes automake to fail if `extra-portability' warnings are enabled. And
it's a good thing this sanity check has started to fail in msvc-for-1.11,
because the `extra-portability2.test' has become broken there; I mean, of
course "automake -Wall -Werror --gnits" won't trip on `extra-portability'
warnings -- they are not enabled by `-Wall' anymore!
Attached is the patch I've pushed to remedy this situation.
> Another snag in the testsuite is that branch-1.11:tests/ltinit.test needs
> the below hunk (or similar) from testsuite-work in order to not fail on
> MinGW.
>
> @@ -57,7 +57,7 @@ $AUTOMAKE -a
> cwd=`pwd`
> ./configure --prefix="$cwd/inst" >stdout || { cat stdout; Exit 1; }
> cat stdout
> -grep '^checking.*dlopen' stdout
> +grep '^checking.*dlfcn\.h.* no$' stdout || grep '^checking.*dlopen' stdout
>
> $MAKE
> $MAKE install
>
Will you do that or should I?
Oh, and BTW, I see that `ltinit.test' is present in `maint' too, so the
right fix is to apply the fix to `maint', and then merge `maint' into
`branch-1.11' (and `master' as well, in fact).
Regards,
Stefano
From 064d00873247444393e8746a0b037b984075fab0 Mon Sep 17 00:00:00 2001
Message-Id: <064d00873247444393e8746a0b037b984075fab0.1320920608.git.stefano.lattar...@gmail.com>
From: Stefano Lattarini <stefano.lattar...@gmail.com>
Date: Thu, 10 Nov 2011 11:23:13 +0100
Subject: [PATCH] tests: fix broken backport of tests on `extra-portability' warnings
* tests/extra-portability2.test: Ensure all the automake invocations
have the warnings in the `extra-portability' category enabled.
Report by Peter Rosin.
---
ChangeLog | 7 +++++++
tests/extra-portability2.test | 4 ++++
2 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 1a4b514..1f2f960 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2011-11-10 Stefano Lattarini <stefano.lattar...@gmail.com>
+
+ tests: fix broken backport of tests on `extra-portability' warnings
+ * tests/extra-portability2.test: Ensure all the automake invocations
+ have the warnings in the `extra-portability' category enabled.
+ Report by Peter Rosin.
+
2011-11-08 Peter Rosin <p...@lysator.liu.se>
tests: fix broken backport of AM_PROG_AR tests
diff --git a/tests/extra-portability2.test b/tests/extra-portability2.test
index a44b144..9a01e74 100755
--- a/tests/extra-portability2.test
+++ b/tests/extra-portability2.test
@@ -43,6 +43,10 @@ END
$ACLOCAL
+# In the 1.11.x series, `extra-portability' warnings are not enabled
+# by `-Wall'.
+AUTOMAKE="$AUTOMAKE -Wextra-portability"
+
# Make sure the test is useful.
AUTOMAKE_fails
--
1.7.2.3
