On Tuesday 07 September 2010, Bruno Haible wrote:
> Hi Stefano,
>
> > I'll try to revert all the wrong cat removals
> Thanks.
>
> > An updated patch is attached.
>
> I would
> 1. write "non-ASCII" instead of "nonprinting".
> [CUT GOOD, LONG EXPLANATION]
OK, will do. (In my defense, I can say that I shamelessly copied the
comments on "not a useless use of cat" from `tests/color.test').
> 2. not change the order of the tests. There's a (possibly not
> visible) logic behind the order. I mean this hunk. Can you please
> swap back the lines 259 and 260?
Will do. And I'll do the same for similar hunks, for consistency.
Sorry for the useless tweaking.
OK to push with the attached change squashed in?
Thanks,
Stefano
diff --git a/tests/pot-linguas.test b/tests/pot-linguas.test
index 8e96b08..dd7bc94 100755
--- a/tests/pot-linguas.test
+++ b/tests/pot-linguas.test
@@ -234,12 +234,13 @@ END
$MAKE install
grep great $sourcedir/posub/foo-bar.pot
# NOTE: This is *not* a useless use of cat. The *.po files can contain
- # nonprinting characters, which might cause problems with some `grep'
- # program. BSD `grep' works from a pipe, but not a seekable file. GNU
- # or BSD `grep -a' works on files, but is not portable.
+ # non-ASCII characters, which might cause problems with some `grep'
+ # programs. BSD `grep' works from a pipe, but not a seekable file.
+ # GNU or BSD `grep -a' works on files, but is not portable.
cat $sourcedir/posub/foo-bar-de.po | grep great
- cat $sourcedir/posub/foo-bar-fr.po | grep great
cmp $sourcedir/posub/foo-bar-de.mobak $sourcedir/posub/foo-bar-de.mo && Exit 1
+ # NOTE: This is *not* a useless use of cat. See comments above.
+ cat $sourcedir/posub/foo-bar-fr.po | grep great
cmp $sourcedir/posub/foo-bar-fr.mobak $sourcedir/posub/foo-bar-fr.mo && Exit 1
cmp $sourcedir/posub/foo-bar-es.pobak $sourcedir/posub/foo-bar-es.po
cmp $sourcedir/posub/foo-bar-es.mobak $sourcedir/posub/foo-bar-es.mo
@@ -256,8 +257,9 @@ END
grep great $sourcedir/posub/foo-bar.pot
# NOTE: This is *not* a useless use of cat. See comments above.
cat $sourcedir/posub/foo-bar-de.po | grep great
- cat $sourcedir/posub/foo-bar-fr.po | grep great
cmp $sourcedir/posub/foo-bar-de.mobak $sourcedir/posub/foo-bar-de.mo && Exit 1
+ # NOTE: This is *not* a useless use of cat. See comments above.
+ cat $sourcedir/posub/foo-bar-fr.po | grep great
cmp $sourcedir/posub/foo-bar-fr.mobak $sourcedir/posub/foo-bar-fr.mo && Exit 1
cmp $sourcedir/posub/foo-bar-es.pobak $sourcedir/posub/foo-bar-es.po
cmp $sourcedir/posub/foo-bar-es.mobak $sourcedir/posub/foo-bar-es.mo
diff --git a/tests/pot-noinst.test b/tests/pot-noinst.test
index 3068cb6..047a328 100755
--- a/tests/pot-noinst.test
+++ b/tests/pot-noinst.test
@@ -227,12 +227,13 @@ END
$MAKE dist
grep great $sourcedir/posub/foo-bar.pot
# NOTE: This is *not* a useless use of cat. The *.po files can contain
- # nonprinting characters, which might cause problems with some `grep'
- # program. BSD `grep' works from a pipe, but not a seekable file. GNU
- # or BSD `grep -a' works on files, but is not portable.
+ # non-ASCII characters, which might cause problems with some `grep'
+ # programs. BSD `grep' works from a pipe, but not a seekable file.
+ # GNU or BSD `grep -a' works on files, but is not portable.
cat $sourcedir/posub/foo-bar-de.po | grep great
- cat $sourcedir/posub/foo-bar-fr.po | grep great
cmp $sourcedir/posub/foo-bar-de.mobak $sourcedir/posub/foo-bar-de.mo && Exit 1
+ # NOTE: This is *not* a useless use of cat. See comments above.
+ cat $sourcedir/posub/foo-bar-fr.po | grep great
cmp $sourcedir/posub/foo-bar-fr.mobak $sourcedir/posub/foo-bar-fr.mo && Exit 1
cmp $sourcedir/posub/foo-bar-es.pobak $sourcedir/posub/foo-bar-es.po
cmp $sourcedir/posub/foo-bar-es.mobak $sourcedir/posub/foo-bar-es.mo
diff --git a/tests/pot-topsrcdir.test b/tests/pot-topsrcdir.test
index a92b9d9..442ea56 100755
--- a/tests/pot-topsrcdir.test
+++ b/tests/pot-topsrcdir.test
@@ -231,12 +231,13 @@ END
$MAKE install
grep great $sourcedir/foo-bar.pot
# NOTE: This is *not* a useless use of cat. The *.po files can contain
- # nonprinting characters, which might cause problems with some `grep'
- # program. BSD `grep' works from a pipe, but not a seekable file. GNU
- # or BSD `grep -a' works on files, but is not portable.
+ # non-ASCII characters, which might cause problems with some `grep'
+ # programs. BSD `grep' works from a pipe, but not a seekable file.
+ # GNU or BSD `grep -a' works on files, but is not portable.
cat $sourcedir/foo-bar-de.po | grep great
- cat $sourcedir/foo-bar-fr.po | grep great
cmp $sourcedir/foo-bar-de.mobak $sourcedir/foo-bar-de.mo && Exit 1
+ # NOTE: This is *not* a useless use of cat. See comments above.
+ cat $sourcedir/foo-bar-fr.po | grep great
cmp $sourcedir/foo-bar-fr.mobak $sourcedir/foo-bar-fr.mo && Exit 1
cmp $sourcedir/foo-bar-es.pobak $sourcedir/foo-bar-es.po
cmp $sourcedir/foo-bar-es.mobak $sourcedir/foo-bar-es.mo
@@ -253,8 +254,9 @@ END
grep great $sourcedir/foo-bar.pot
# NOTE: This is *not* a useless use of cat. See comments above.
cat $sourcedir/foo-bar-de.po | grep great
- cat $sourcedir/foo-bar-fr.po | grep great
cmp $sourcedir/foo-bar-de.mobak $sourcedir/foo-bar-de.mo && Exit 1
+ # NOTE: This is *not* a useless use of cat. See comments above.
+ cat $sourcedir/foo-bar-fr.po | grep great
cmp $sourcedir/foo-bar-fr.mobak $sourcedir/foo-bar-fr.mo && Exit 1
cmp $sourcedir/foo-bar-es.pobak $sourcedir/foo-bar-es.po
cmp $sourcedir/foo-bar-es.mobak $sourcedir/foo-bar-es.mo
