Hi Stefano,
> I'll try to revert all the wrong cat removals
Thanks.
> An updated patch is attached.
I would
1. write "non-ASCII" instead of "nonprinting". Whether a character is
printing or not, depends on the character set and encoding - it is not
an absolute term. The character "ò" _is_ a printing character - when
you consider the UTF-8 encoding, that is declared in the PO file.
The problem is that OpenBSD 4.0 'grep' assumes the ASCII encoding
(possibly because we run it in "C" locale, possibly because it is
hardcoded, I don't know).
2. not change the order of the tests. There's a (possibly not visible)
logic behind the order. I mean this hunk. Can you please swap back
the lines 259 and 260?
> diff --git a/tests/pot-linguas.test b/tests/pot-linguas.test
> index 7f7f42f..8e96b08 100755
> --- a/tests/pot-linguas.test
> +++ b/tests/pot-linguas.test
> @@ -250,16 +254,18 @@ END
> cp -p $sourcedir/posub/foo-bar-fr.mobak $sourcedir/posub/foo-bar-fr.mo
> $MAKE dist
> grep great $sourcedir/posub/foo-bar.pot
> - grep great $sourcedir/posub/foo-bar-de.po
> + # NOTE: This is *not* a useless use of cat. See comments above.
> + cat $sourcedir/posub/foo-bar-de.po | grep great
> + cat $sourcedir/posub/foo-bar-fr.po | grep great
> cmp $sourcedir/posub/foo-bar-de.mobak $sourcedir/posub/foo-bar-de.mo &&
> Exit 1
> - grep great $sourcedir/posub/foo-bar-fr.po
> cmp $sourcedir/posub/foo-bar-fr.mobak $sourcedir/posub/foo-bar-fr.mo &&
> Exit 1
> cmp $sourcedir/posub/foo-bar-es.pobak $sourcedir/posub/foo-bar-es.po
> cmp $sourcedir/posub/foo-bar-es.mobak $sourcedir/posub/foo-bar-es.mo
Bruno
