On Sun, Mar 19, 2006 at 07:13:44AM +0100, Ralf Wildenhues wrote: > * Ralf Wildenhues wrote on Sun, Mar 19, 2006 at 06:46:24AM CET: [about "if $MAKE; then false; fi"] > > * Alexandre Duret-Lutz wrote on Sat, Mar 18, 2006 at 07:28:14AM CET: > > > Let's write "$MAKE && exit 1" because that's what of the other test do, > > > and > > > I'm wary that some shell will return the $? of $MAKE if it fails, in turn > > > causing "set -e" to abort the script. Don't ask me which shell, but > > > that's > > > why we have "else :; fi" all over the Makefiles. > > > > I always thought that was because of the `sh -e -c "$cmd"' that some > > make implementations used (see Autoconf portability section).
Isn't that exactly what I'm saying? > And then I applied this patch to fix our thinko. :-) Huh??? Those two lines are fully equivalent to me. > - $MAKE && exit 1 > + if $MAKE; then false; else :; fi
