* Ralf Wildenhues wrote on Sun, Mar 19, 2006 at 06:46:24AM CET:
> * Alexandre Duret-Lutz wrote on Sat, Mar 18, 2006 at 07:28:14AM CET:
> > Let's write "$MAKE && exit 1" because that's what of the other test do, and
> > I'm wary that some shell will return the $? of $MAKE if it fails, in turn
> > causing "set -e" to abort the script. Don't ask me which shell, but that's
> > why we have "else :; fi" all over the Makefiles.
>
> I always thought that was because of the `sh -e -c "$cmd"' that some
> make implementations used (see Autoconf portability section).
And then I applied this patch to fix our thinko. :-)
Cheers,
Ralf
* tests/depcomp6.test, tests/depcomp7.test: Fix failure logic
to work with `set -e'.
Index: tests/depcomp6.test
===================================================================
RCS file: /cvs/automake/automake/tests/depcomp6.test,v
retrieving revision 1.1
diff -u -r1.1 depcomp6.test
--- tests/depcomp6.test 19 Mar 2006 05:45:33 -0000 1.1
+++ tests/depcomp6.test 19 Mar 2006 06:04:19 -0000
@@ -98,5 +98,5 @@
cd sub2
$sleep
echo 'choke me' > sub3/ba3.h
- $MAKE && exit 1
+ if $MAKE; then false; else :; fi
fi
Index: tests/depcomp7.test
===================================================================
RCS file: /cvs/automake/automake/tests/depcomp7.test,v
retrieving revision 1.1
diff -u -r1.1 depcomp7.test
--- tests/depcomp7.test 19 Mar 2006 05:45:33 -0000 1.1
+++ tests/depcomp7.test 19 Mar 2006 06:04:19 -0000
@@ -100,5 +100,5 @@
cd sub2
$sleep
echo 'choke me' > sub3/ba3.h
- $MAKE && exit 1
+ if $MAKE; then false; else :; fi
fi
