Hi Ralf, > Instead of logically splitting up the check here, how about adding an > argument, as below? (I'm a bit unsure myself, but it looks somewhat > cleaner this way, as it prevents the user from screwing up by forgetting > the AT_CLEANUP inadvertently.) > > # AT_CHECK_AT(TITLE, SUITE-CODE, [XFAIL-CONDITION], [STATUS = 0], > -# [STDOUT := ignore], STDERR) > +# [STDOUT := ignore], STDERR, [POST-TEST-CODE]) > # --------------------------------------------------------------- > # Create a new test named TITLE that runs a minimal Autotest test suite, > # SUITE-CODE. Call AT_XFAIL_IF with XFAIL-CONDITION. STATUS and STDERR pass > # directly to the AT_CHECK that call the minimal test suite. STDOUT is not > -# used, but it is reserved for future use. > +# used, but it is reserved for future use. Put additional toplevel tests > +# code in POST-TEST-CODE.
I like your idea better. I will resubmit with that paradigm. More comments coming to your other reply. -- Eric Blake
