Hi Eric, I still need to look at the rest, but one comment for now.
* Eric Blake wrote on Sat, Apr 08, 2006 at 03:16:33AM CEST: > --- tests/autotest.at 5 Apr 2006 16:04:22 -0000 1.11 > +++ tests/autotest.at 8 Apr 2006 00:57:29 -0000 > @@ -19,14 +19,15 @@ AT_BANNER([Autotest.]) > # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA > # 02110-1301, USA. > > -# AT_CHECK_AT(TITLE, SUITE-CODE, [XFAIL-CONDITION], [STATUS = 0], > -# [STDOUT := ignore], STDERR) > -# --------------------------------------------------------------- > +# AT_CHECK_AT_START(TITLE, SUITE-CODE, [XFAIL-CONDITION], [STATUS = 0], > +# [STDOUT := ignore], STDERR) > +# --------------------------------------------------------------------- Instead of logically splitting up the check here, how about adding an argument, as below? (I'm a bit unsure myself, but it looks somewhat cleaner this way, as it prevents the user from screwing up by forgetting the AT_CLEANUP inadvertently.) Cheers, and thanks! Ralf Index: tests/autotest.at =================================================================== RCS file: /cvsroot/autoconf/autoconf/tests/autotest.at,v retrieving revision 1.11 diff -u -r1.11 autotest.at --- tests/autotest.at 5 Apr 2006 16:04:22 -0000 1.11 +++ tests/autotest.at 8 Apr 2006 09:55:46 -0000 @@ -20,12 +20,13 @@ # 02110-1301, USA. # AT_CHECK_AT(TITLE, SUITE-CODE, [XFAIL-CONDITION], [STATUS = 0], -# [STDOUT := ignore], STDERR) +# [STDOUT := ignore], STDERR, [POST-TEST-CODE]) # --------------------------------------------------------------- # Create a new test named TITLE that runs a minimal Autotest test suite, # SUITE-CODE. Call AT_XFAIL_IF with XFAIL-CONDITION. STATUS and STDERR pass # directly to the AT_CHECK that call the minimal test suite. STDOUT is not -# used, but it is reserved for future use. +# used, but it is reserved for future use. Put additional toplevel tests +# code in POST-TEST-CODE. m4_define([AT_CHECK_AT], [ AT_SETUP([$1]) @@ -49,6 +50,7 @@ AT_CHECK_AUTOM4TE([--language=autotest -o micro-suite mysuite.at]) AT_CHECK([$CONFIG_SHELL ./micro-suite], m4_default([$4], 0), [ignore], [$6]) AT_CHECK([$CONFIG_SHELL ./micro-suite -v -x], m4_default([$4], 0), [ignore], [$6]) +$7 AT_CLEANUP ])
