> having the import at the bottom is but that can be considered again as 'not a violation'
That's not the issue I am trying to solve with that PR. > 2nd it is not a real import and is already confusing I know it's not a real import but ansible made it look like a real import so coding styles should apply. > Your change makes it even more misleading as it implies a restricted import which is not true My change only makes a completely arbitrary line that we are forced to add to comply to coding standards. The misleading part comes from making a line that looks like an import to do something that is definitively not an import : ) (I wonder how many people contributing to ansible know that line is actually not an import). > Last, but not least, we don't enforce PEP8 nor are particularly keen on following it blindly as many others do. You can follow any coding style that you prefer. It's your decision. I decided to write PEP8 compliant code and you are forcing me to write code that is not compliant by forcing me to write a wildcard import. On Saturday, 5 March 2016 07:04:38 UTC+1, Alexey Vazhnov wrote: > > And this is bad. This can alienate new developers. I like Python because > it have formatting standards. When I open Ansible source files in my VIM > with installed vim-syntastic, I see too much bad formatting. And I begin > formatting fixing at first, instead of writing/fixing code. > Please, let us possibility to fix formatting issues. > > On Friday, March 4, 2016 at 10:30:59 PM UTC+5, Brian Coca wrote: >> >> PEP8 only changes are not normally accepted. >> >> >> >> ---------- >> Brian Coca >> > -- You received this message because you are subscribed to the Google Groups "Ansible Project" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/bf3191ad-df21-4b21-9f8a-f278cd0e119c%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
