Hello,
when writing ansible modules, ansible requires you to add the following 
line:

from ansible.module_utils.<lib name> import *

which breaks PEP8. The solution is rather simple and is proposed in the 
following PR:

https://github.com/ansible/ansible/pull/14805

The patch allows you to import either

from ansible.module_utils.<lib name> import *

or

from ansible.module_utils.<lib name> import AnsibleModule

without breaking anything as you can see in the tests:

https://travis-ci.org/ansible/ansible/builds/113691610

I understand that line is not a real import and you replace it with ansible 
code so you can ship a single file to the remote host (which the sanity of 
the idea could be argued but it's not the point of this thread). However, 
you made it look like a real import that breaks PEP8 so I don't understand 
why my PR was rejected without further discussion. Specially when the patch 
is so simple and transparent and allows people to write PEP8 compliant code.

Thanks for your time.
David Barroso

-- 
You received this message because you are subscribed to the Google Groups 
"Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/ansible-project/dce3d229-13e0-43c0-b30e-730972320783%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to