On Tue, Nov 19, 2019 at 8:52 PM Luben Tuikov <[email protected]> wrote:
> On 2019-11-14 10:34 p.m., Aaron Liu wrote: > > From: Huang Rui <[email protected]> > > > > To align the kernel uapi change from Alex: > > > > "Add a flag to the GEM_CREATE ioctl to create encrypted buffers. Buffers > with > > this flag set will be created with the TMZ bit set in the PTEs or engines > > accessing them. This is required in order to properly access the data > from the > > engines." > > > > We will use GEM_CREATE_ENCRYPTED flag for secure buffer allocation. > > > > Signed-off-by: Huang Rui <[email protected]> > > Reviewed-by: Alex Deucher <[email protected]> > > --- > > include/drm/amdgpu_drm.h | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h > > index 5c28aa7..1a95e37 100644 > > --- a/include/drm/amdgpu_drm.h > > +++ b/include/drm/amdgpu_drm.h > > @@ -141,6 +141,11 @@ extern "C" { > > * releasing the memory > > */ > > #define AMDGPU_GEM_CREATE_VRAM_WIPE_ON_RELEASE (1 << 9) > > +/* Flag that BO will be encrypted and that the TMZ bit should be > > + * set in the PTEs when mapping this buffer via GPUVM or > > + * accessing it with various hw blocks > > + */ > > +#define AMDGPU_GEM_CREATE_ENCRYPTED (1 << 10) > > Style! > TAB char?! > > You have a TAB char between ".._ENCRYPTED" and "(1 << 10)" > Do NOT add/insert TAB chars instead of space to align colunmns! > If when you press Tab key a tab is inserted, as opposed to the line > indented, then DO NOT use this editor. > The Tab key should "indent according to mode" by inserting TAB chars. > If the line is already indented, as this one is, then it should do nothing. > I disagree with this 100%. Tabs or spaces don't matter here from my perspective. I also disagree with your language. It's overly impolite. Marek
_______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
