We can't land the kernel side until we have real userspace (e.g., Mesa) that uses the TMZ interfaces. The unit tests are not enough.
Alex ________________________________ From: Christian König <[email protected]> Sent: Friday, November 15, 2019 7:56 AM To: Liu, Aaron <[email protected]>; [email protected] <[email protected]> Cc: Olsak, Marek <[email protected]>; Huang, Ray <[email protected]>; Tuikov, Luben <[email protected]>; Deucher, Alexander <[email protected]>; Liu, Leo <[email protected]>; Koenig, Christian <[email protected]> Subject: Re: [PATCH 01/12] amdgpu: add UAPI for creating encrypted buffers Am 15.11.19 um 04:34 schrieb Aaron Liu: > From: Huang Rui <[email protected]> > > To align the kernel uapi change from Alex: > > "Add a flag to the GEM_CREATE ioctl to create encrypted buffers. Buffers with > this flag set will be created with the TMZ bit set in the PTEs or engines > accessing them. This is required in order to properly access the data from the > engines." > > We will use GEM_CREATE_ENCRYPTED flag for secure buffer allocation. > > Signed-off-by: Huang Rui <[email protected]> > Reviewed-by: Alex Deucher <[email protected]> Please read up on how amdpu_drm.h is updated. The change must first land upstream and then the file is synced up somehow semi-automatic. Christian. > --- > include/drm/amdgpu_drm.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h > index 5c28aa7..1a95e37 100644 > --- a/include/drm/amdgpu_drm.h > +++ b/include/drm/amdgpu_drm.h > @@ -141,6 +141,11 @@ extern "C" { > * releasing the memory > */ > #define AMDGPU_GEM_CREATE_VRAM_WIPE_ON_RELEASE (1 << 9) > +/* Flag that BO will be encrypted and that the TMZ bit should be > + * set in the PTEs when mapping this buffer via GPUVM or > + * accessing it with various hw blocks > + */ > +#define AMDGPU_GEM_CREATE_ENCRYPTED (1 << 10) > > /* Hybrid specific */ > /* Flag that the memory allocation should be from top of domain */
_______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
