This patch is :-
Reviewed-by: Sathishkumar S <[email protected]>

On 7/12/2025 4:09 AM, Alex Deucher wrote:
Start and stop can fail, so add checks.

Fixes: 74894ffc7d0c ("drm/amdgpu: Add ring reset callback for JPEG4_0_0")
Signed-off-by: Alex Deucher <[email protected]>
Cc: Sathishkumar S <[email protected]>
---
  drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c | 8 ++++++--
  1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c 
b/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c
index 1d4edd77837d0..78fe1924f3cb7 100644
--- a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c
@@ -730,8 +730,12 @@ static int jpeg_v4_0_ring_reset(struct amdgpu_ring *ring,
                return -EINVAL;
drm_sched_wqueue_stop(&ring->sched);
-       jpeg_v4_0_stop(ring->adev);
-       jpeg_v4_0_start(ring->adev);
+       r = jpeg_v4_0_stop(ring->adev);
+       if (r)
+               return r;
+       r = jpeg_v4_0_start(ring->adev);
+       if (r)
+               return r;
        r = amdgpu_ring_test_helper(ring);
        if (r)
                return r;

Reply via email to