Reviewed-by: Felix Kuehling <[email protected]>

On 17-07-12 04:31 AM, Christian König wrote:
> From: Christian König <[email protected]>
>
> Printing a warning into the logs that we will certainly run into a BUG() is
> completely nonsense, the BUG() is more than noisy enough.
>
> Signed-off-by: Christian König <[email protected]>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index ba3bfc3..db2dede 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -1043,8 +1043,7 @@ static int amdgpu_vm_update_level(struct amdgpu_device 
> *adev,
>       params.adev = adev;
>       shadow = parent->bo->shadow;
>  
> -     WARN_ON(vm->use_cpu_for_update && shadow);
> -     if (vm->use_cpu_for_update && !shadow) {
> +     if (vm->use_cpu_for_update) {
>               r = amdgpu_bo_kmap(parent->bo, (void **)&pd_addr);
>               if (r)
>                       return r;
> @@ -1310,9 +1309,6 @@ static int amdgpu_vm_update_ptes(struct 
> amdgpu_pte_update_params *params,
>                       r = amdgpu_bo_kmap(pt, (void *)&pe_start);
>                       if (r)
>                               return r;
> -
> -                     WARN_ONCE(pt->shadow,
> -                               "CPU VM update doesn't suuport shadow pages");
>               } else {
>                       if (pt->shadow) {
>                               pe_start = amdgpu_bo_gpu_offset(pt->shadow);

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to