malteveerman added inline comments.

INLINE COMMENTS

> FindMySQLe.cmake:45
> +        # below.
> +        set(MYSQLE_LIBRARIES ${MYSQL_LIBRARIES})
> +    else()

This breaks embedded for me. The embedded storage plugin silently links against 
libmysqlclient and then fails when initializing.
It's a problem that exists independently of this revision but I thought we 
could fix it here as well.
I'm on Arch where `--libmysql-libs` doesn't exist either.

REPOSITORY
  R181 Amarok

BRANCH
  mysqle-split-for-phab

REVISION DETAIL
  https://phabricator.kde.org/D28284

To: asturmlechner, #amarok, heikobecker, wbauer
Cc: malteveerman, amarok-devel, vmatare, mdn, pgomes, nicolamori, jyasi, 
mfraser, ryanmccoskrie, semareit, eridani, eoinoneill, jackyalcine, nhuisman, 
paul, domson, yaohanchen, markey, James, tbettler, Smar, ricktimmis, 
asturmlechner, schweingruber, heikobecker

Reply via email to