----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109470/#review30950 -----------------------------------------------------------
> Adds the proper fix along with the not affecting cached lyrics stuff. I don't see it. > Should I removenthe cached lyrics completely? Yes, please remove the unneeded changes to cached lyrics you introduced earlier. Also please remove the unrelated and harmful changes to CMakeLists.txt - commenting-out macro_optional_find_package is obviously a bad idea! - Matěj Laitl On April 4, 2013, 11:37 p.m., mayank jha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109470/ > ----------------------------------------------------------- > > (Updated April 4, 2013, 11:37 p.m.) > > > Review request for Amarok. > > > Description > ------- > > It required modifications, when there is no change in the lyrics downloaded > and lyrics retrieved from cache the title display of the lyrics browser > changes to "Cached Lyrics" from "Lyrics" so we can tell the difference > between old and new. > > > Diffs > ----- > > CMakeLists.txt d167577 > src/context/applets/lyrics/LyricsApplet.cpp 2394964 > src/context/engines/lyrics/LyricsEngine.h b187b73 > src/context/engines/lyrics/LyricsEngine.cpp 2befa91 > src/core-impl/collections/nepomukcollection/CMakeLists.txt 642919b > > Diff: http://git.reviewboard.kde.org/r/109470/diff/ > > > Testing > ------- > > Its working fine! > > > Thanks, > > mayank jha > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
