----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109283/#review28687 -----------------------------------------------------------
Nice, all the issues were resolved correctly. I've spotted one more minor issue, an issue in new code and I have a config dialog suggestion. File Attachment: screen shot of the last fm service settings <http://git.reviewboard.kde.org//r/109283/#fcomment36> Could you try to make this one the one line, e.g. the QComboBox directly on the right of QCheckBox? (you'll probably need QHVBoxLayout + spacer on the right for correct behaviour) src/services/lastfm/LastFmServiceSettings.h <http://git.reviewboard.kde.org/r/109283/#comment21452> ( const Meta::LabelList &labels ) would be better. src/services/lastfm/ScrobblerAdapter.cpp <http://git.reviewboard.kde.org/r/109283/#comment21453> Logic error, you probably meant !m_config->filterByLabel() - Matěj Laitl On March 6, 2013, 9:34 a.m., Vedant Agarwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109283/ > ----------------------------------------------------------- > > (Updated March 6, 2013, 9:34 a.m.) > > > Review request for Amarok. > > > Description > ------- > > Added a check-box to disable scobbling for tracks with a particular label. > The label can be selected from a drop-down list or entered manually. Any > track that contains this label is skipped from being submitted to last.fm for > being scrobbled. > > > Diffs > ----- > > src/services/lastfm/LastFmConfigWidget.ui 5c5e51b > src/services/lastfm/LastFmServiceConfig.h 3f33b72 > src/services/lastfm/LastFmServiceSettings.h 41b2ead > src/services/lastfm/LastFmServiceSettings.cpp f6e1564 > src/services/lastfm/ScrobblerAdapter.h ea74196 > src/services/lastfm/ScrobblerAdapter.cpp b1a09f8 > src/statsyncing/Process.cpp c42fdc4 > src/statsyncing/ScrobblingService.h 971edd7 > > Diff: http://git.reviewboard.kde.org/r/109283/diff/ > > > Testing > ------- > > Builds and runs successfully. > > > File Attachments > ---------------- > > screen shot of the last fm service settings > > http://git.reviewboard.kde.org/media/uploaded/files/2013/03/06/modifiedLastFm.png > > > Thanks, > > Vedant Agarwala > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
