----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101598/ -----------------------------------------------------------
(Updated Feb. 4, 2012, 4:32 p.m.) Review request for Amarok. Changes ------- Made changes as suggested by Mat?j Laitl: Removed non related changes in TagHelper.cpp and added file type resolving by mime type in FileTypeResolver.cpp. Description ------- This patch adds read/write tag support for mod, s3m, it and xm files if taglib supports it. All new parts are #ifdefed so it won't break if an old taglib version is used. I wrote a patch for taglib that enables support for these file formats and it will be included in taglib 1.8.0. Here is the pull request: https://github.com/taglib/taglib/pull/4 This addresses bug 90524. https://bugs.kde.org/show_bug.cgi?id=90524 Diffs (updated) ----- CMakeLists.txt d47c28b config-amarok.h.cmake 2d25cc7 shared/FileType.h 5c8081f shared/FileType.cpp a6e25d5 shared/FileTypeResolver.cpp e69a514 shared/tag_helpers/TagHelper.cpp 4c0fb2b Diff: http://git.reviewboard.kde.org/r/101598/diff/diff Testing ------- Thanks, Mathias Stephan Panzenböck
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
