----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101598/#review3900 -----------------------------------------------------------
Style and logic looks OK to me. I can't comment on the functionality since I'm pretty much clueless about collectionscanner and taglib. - Bart On June 13, 2011, 1:59 a.m., Mathias Stephan Panzenböck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101598/ > ----------------------------------------------------------- > > (Updated June 13, 2011, 1:59 a.m.) > > > Review request for Amarok. > > > Summary > ------- > > This patch adds read-only tag support for s3m, it and xm files. It uses a > taglib extension library I wrote (TagLib-Mod): > https://bitbucket.org/panzi/taglib-mod > > This library is a soft dependency. If it is not found the feature is not > compiled. > > I've also sent a pull request to the taglib project: > https://github.com/taglib/taglib/pull/4 > > > This addresses bug 90524. > https://bugs.kde.org/show_bug.cgi?id=90524 > > > Diffs > ----- > > CMakeLists.txt d1abe26 > shared/FileType.h 5c8081f > shared/FileType.cpp a6e25d5 > shared/tag_helpers/TagHelper.cpp 96f763e > src/App.cpp 48ba1d9 > src/CMakeLists.txt b5b5689 > src/core-impl/collections/db/sql/CMakeLists.txt dac9598 > utilities/collectionscanner/CMakeLists.txt e712485 > > Diff: http://git.reviewboard.kde.org/r/101598/diff > > > Testing > ------- > > > Thanks, > > Mathias Stephan > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
