----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103271/ -----------------------------------------------------------
Review request for Amarok. Description ------- Fix infinite loop in context view eating CPU until main window is shown We used to use _scene_ sceneRect in VerticalToolbarContainment::updateGeometry() to update applets and geometry, but that leaded to infinite loop (across mainloop) - m_applets->setGeometry(), refresh() would enlarge _scene_ sceneRect by a few pixels which would trigger updateGeometry() and so on... We now use _view_ sceneRect to update geometry. BUG: 278897 FIXED-IN: 2.5 Diffs ----- ChangeLog a99a4de75b1941ecdc7cb3b41cce9ad3c996df27 src/context/containments/verticallayout/VerticalToolbarContainment.cpp 99fe147ab7b4d5ba8ca6f156a544d4066b1dc3da Diff: http://git.reviewboard.kde.org/r/103271/diff/diff Testing ------- Amarok doesn't eat CPU on start anymore. Thanks, Matěj Laitl
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
