----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101155/#review2786 -----------------------------------------------------------
Didn't test the patch but the concept and code look good. How many tracks did you test this with? With all lyrics providers? Does the scroll line up with the actual song in all of the cases? - Bart On April 19, 2011, 5:07 p.m., Jan Gerrit Marker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101155/ > ----------------------------------------------------------- > > (Updated April 19, 2011, 5:07 p.m.) > > > Review request for Amarok. > > > Summary > ------- > > The text of the current song is automatically scrolled according to the > position in the song. If the scrollbar is pressed and moved the autoscroll is > disabled till the scollbar is released and it can be disabled/reactivated > manually by clicking on an action. Whether autoscrolling is enabled or > disabled is saved over Amarok restarts. > > > Diffs > ----- > > src/context/applets/lyrics/LyricsApplet.h 17c91bf > src/context/applets/lyrics/LyricsApplet.cpp a9c6be3 > > Diff: http://git.reviewboard.kde.org/r/101155/diff > > > Testing > ------- > > Tested and worked fine. > > > Thanks, > > Jan Gerrit > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
