On Fri, 2017-10-13 at 19:08 +0200, Francesco wrote: > Hi, > > > > > I would suggest to start simple. Just use the int for now, and > > document > > the limitation. The context option will have to be DRAFT anyway for > > at > > least a while, so it can be changed if necessary. Then we can > > iterate. > > > > I agree. I just completed the changes and submitted a first PR to > allow you > to comment on the proposed change. > > Unfortunately I found out that there are no automated tests about > ZMQ_THREAD_PRIORITY and ZMQ_THREAD_SCHED_POLICY options; thus to test > my > changes I modified tests/test_ctx_options.cpp to add new calls. If > you > uncomment the sleep() call I put there, you can use "top" or > "taskset" to > verify that the change works correctly. > Unfortunately I have no good idea on how to implement automated > testing of > such options; the only way I see would be to add a getter of the > thread IDs > (TIDs aka PIDs) of background threads... > > Let me know what you think about that. > > Thanks, > Francesco
Hi, Yes that is fine, it's fairly straight forward usage of an OS API so as long as we can check that our code to take in the option and pass it down works, that's enough. Kind regards, Luca Boccassi
signature.asc
Description: This is a digitally signed message part
_______________________________________________ zeromq-dev mailing list [email protected] https://lists.zeromq.org/mailman/listinfo/zeromq-dev
