On Wed, 2010-08-04 at 11:56 +0200, Michel Dänzer wrote: > On Mon, 2010-08-02 at 13:56 -0400, Adam Jackson wrote: > > On Mon, 2010-08-02 at 18:24 +0200, Michel Dänzer wrote: > > > > > AFAICT this will only work when using the 'built-in' mode, otherwise > > > mode->PrivFlags will never be set? One possible solution for that could > > > be > > > > > > - var->pixclock = mode->Clock ? 1000000000/mode->Clock : 0; > > > + var->pixclock = mode->PrivFlags ? mode->PrivFlags : > > > (mode->Clock ? 1000000000/mode->Clock : 0); > > > > > > in xfree2fbdev_timing(). > > > > Right you are. > > > > So I guess the question is what we're trying to accomplish with the > > fbdev_modes_equal() check at all. > > From commit f6815cb68b0f6698497348fc6e4214dacef33b95 which added it: > > The fbdev API allows the driver to 'accept' modes it doesn't really > support by > modifying it to the nearest supported mode. Without this check, e.g. > vesafb > would appear to accept all modes, even though it actually can't set > any modes > other than the bootup mode at all.
That sure does sound like a vesafb bug. But I suppose in the absence of fixing that, just dropping the pixclock check from fbdev_modes_equal is the least wrong thing. - ajax
signature.asc
Description: This is a digitally signed message part
_______________________________________________ [email protected]: X.Org support Archives: http://lists.freedesktop.org/archives/xorg Info: http://lists.freedesktop.org/mailman/listinfo/xorg Your subscription address: [email protected]
