I think I reviewed all the non-code patches and they looked fine
except for a couple I replied on. Most of the warning fixes seemed
fine to me, too, but I'd be lying if I said I was the master of the C
specification or knowing the xserver SDK.

So, I think you could push all the distcheck-type fixes. Especially
for the unused drivers.

One thing that would be nice is if you could inline the patches. That
would make reviewing faster. Below is my git send-email cheat sheet if
that helps. You can always play around with --dry-run and see if the
right thing is being produced.

~/.gitconfig settings
[sendemail]
        bcc = [email protected]
        chainreplyto = false
        smtpserver = smtp.gmail.com
        smtpssl = true
        smtpuser = [email protected]
        suppresscc = self
        #signedoffcc = false
        #suppressfrom = true

Single patch: (add --no-thread to skip prompt for Message-ID):
git format-patch -s HEAD^
git send-email --to $list 0001-*.patch

Patch series from branch:
git format-patch -n -s -o $patchdir --cover-letter master
$EDITOR $patchdir/0000-cover-letter.patch
git send-email --to $list $patchdir

--
Dan
_______________________________________________
xorg mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/xorg

Reply via email to