On 12/7/21 11:48 AM, Thomas Klausner wrote:
On Tue, Dec 07, 2021 at 10:47:35AM -0800, Alan Coopersmith wrote:
On 12/6/21 11:59 PM, Thomas Klausner wrote:
When updating the pkgsrc patches to 1.4.2, I noticed quite a lot of warnings.
Here are patches that remove most.
Thanks - since we've switched from email to gitlab for patch submission, I've
converted these to a merge request at:
https://gitlab.freedesktop.org/xorg/app/xscope/-/merge_requests/5
Oh, I didn't know that. Thanks. I'll take a closer look at that for future
fixes.
../fd.c: In function ‘MainLoop’:
../fd.c:432:1: warning: function might be candidate for attribute ‘noreturn’
[-Wsuggest-attribute=noreturn]
432 | MainLoop(void)
| ^~~~~~~~
is unfixed since I could mark it _X_NORETURN but then I'd have to remove
the "return 0" at the end too -- is tha tok?
I think so.
Ok, the attached patch fixes this one as well.
Thanks - these are all merged now.
--
-Alan Coopersmith- [email protected]
Oracle Solaris Engineering - https://blogs.oracle.com/solaris
