So add another check for cygwin or disable getpagesize use on windows? On Sat, Mar 9, 2019 at 7:35 AM <[email protected]> wrote:
> Send xorg-devel mailing list submissions to > [email protected] > > To subscribe or unsubscribe via the World Wide Web, visit > https://lists.x.org/mailman/listinfo/xorg-devel > or, via email, send a message with subject or body 'help' to > [email protected] > > You can reach the person managing the list at > [email protected] > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of xorg-devel digest..." > Today's Topics: > > 1. [PATCH xman] Fix typo in manual page. (Matthieu Herrb) > 2. Re: [PATCH xman] Fix typo in manual page. (Alan Coopersmith) > 3. Re: [PATCH libXaw] Add definition of getpagesize(), missing > on Windows. (Jon Turney) > > > > ---------- Forwarded message ---------- > From: Matthieu Herrb <[email protected]> > To: [email protected] > Cc: > Bcc: > Date: Fri, 8 Mar 2019 21:47:33 +0100 > Subject: [PATCH xman] Fix typo in manual page. > reported by Alejandro G. Peregrina on OpenBSD tech@ list > > Signed-off-by: Matthieu Herrb <[email protected]> > --- > man/xman.man | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man/xman.man b/man/xman.man > index 5edb892..d9e3667 100644 > --- a/man/xman.man > +++ b/man/xman.man > @@ -152,7 +152,7 @@ n(n) New > o(o) Old > > .fi > -Xman will read any section that is of the from \fIman<character>\fP, where > +Xman will read any section that is of the form \fIman<character>\fP, where > <character> is an upper or lower case letter (they are treated > distinctly) or > a numeral (0-9). Be warned, however, that man(__appmansuffix__) and > catman(__adminmansuffix__) will not search directories that are > non-standard. > -- > 2.20.1 > > > > > > ---------- Forwarded message ---------- > From: Alan Coopersmith <[email protected]> > To: Matthieu Herrb <[email protected]>, [email protected] > Cc: > Bcc: > Date: Fri, 8 Mar 2019 13:10:30 -0800 > Subject: Re: [PATCH xman] Fix typo in manual page. > Damn I had to stare at that until my eyes crossed to spot the change of > from -> form... > > Reviewed-by: Alan Coopersmith <[email protected]> > > -alan- > > On 03/ 8/19 12:47 PM, Matthieu Herrb wrote: > > reported by Alejandro G. Peregrina on OpenBSD tech@ list > > > > Signed-off-by: Matthieu Herrb <[email protected]> > > --- > > man/xman.man | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/man/xman.man b/man/xman.man > > index 5edb892..d9e3667 100644 > > --- a/man/xman.man > > +++ b/man/xman.man > > @@ -152,7 +152,7 @@ n(n) New > > o(o) Old > > > > .fi > > -Xman will read any section that is of the from \fIman<character>\fP, > where > > +Xman will read any section that is of the form \fIman<character>\fP, > where > > <character> is an upper or lower case letter (they are treated > distinctly) or > > a numeral (0-9). Be warned, however, that man(__appmansuffix__) and > > catman(__adminmansuffix__) will not search directories that are > non-standard. > > > > > -- > -Alan Coopersmith- [email protected] > Oracle Solaris Engineering - https://blogs.oracle.com/alanc > > > > > ---------- Forwarded message ---------- > From: Jon Turney <[email protected]> > To: Alan Coopersmith <[email protected]>, James R Larrowe < > [email protected]>, xorg-devel <[email protected]> > Cc: > Bcc: > Date: Sat, 9 Mar 2019 01:19:33 +0000 > Subject: Re: [PATCH libXaw] Add definition of getpagesize(), missing on > Windows. > On 05/03/2019 17:43, Alan Coopersmith wrote: > > What's wrong with it is mainly that the set of people who know about X > > libraries > > on Windows is small, and the set of people who deal with libXaw is > > small, and > > the intersection of those two sets is tiny. (It also doesn't help that > > we've > > sucked for years at handling patches by email for the unmaintained > > modules like > > libXaw - we're trying to get better with gitlab merge requests now, but > > we're > > still not great - unmaintained modules are still not well maintained.) > > > > I was hoping one of our Windows folks would comment on whether or not > > that's the > > right way to handle this, or if there's some Windows header to include > > instead. > > But if no one pipes up soon, I'll likely just go ahead and push it and > > see if > > anyone complains afterwards that it broke something. > > > > -Alan Coopersmith- [email protected] > > Oracle Solaris Engineering - https://blogs.oracle.com/alanc > > > > On 03/ 4/19 06:54 AM, James Larrowe wrote: > >> Ping. Anything wrong with this? It's only defined in the plugin header > >> files for gcc. > > I guess this means that you're using a MinGW-type Windows-targetted gcc > and this function is present in libgcc.a (for who knows what historical > reason...), which is turning on HAVE_GETPAGESIZE? > > In that environment, I think there is a unistd.h, which could be > included to provide a prototype. > > Alternatively, since getpagesize() is a POSIX function, and not in the > Windows API, it's possibly more correct for this code not to be used at > all on Windows? > > James: Going forward, if you'd like to Cc: me on your patches, I will do > my best to give them review. > > >> On Thu, Feb 28, 2019 at 12:56 PM James R Larrowe > >> <[email protected] <mailto:[email protected]>> wrote: > >> > >> Fix build with --enable-selective-werror. > >> > >> Signed-off-by: James R Larrowe <[email protected] > >> <mailto:[email protected]>> > >> --- > >> src/OS.c | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/src/OS.c b/src/OS.c > >> index 4c69005..cd0c517 100644 > >> --- a/src/OS.c > >> +++ b/src/OS.c > >> @@ -37,6 +37,9 @@ _XawGetPageSize(void) > >> #endif > >> > >> #ifdef HAVE_GETPAGESIZE > >> +# if defined(_WIN32) > > Also note that, unfortunately, since _WIN32 is overloaded as meaning > both "the target is Win32" and "the Win32 API is available", this > construction can cause difficulties when compiling for the Cygwin target > if "windows.h" has got included somewhere. > > >> +extern int getpagesize(void); > >> +# endif > >> if (pagesize == -1) > >> pagesize = getpagesize(); > >> #endif > >> -- 2.11.0 > >> > > _______________________________________________ > xorg-devel mailing list > [email protected] > https://lists.x.org/mailman/listinfo/xorg-devel
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
