What's wrong with it is mainly that the set of people who know about X libraries
on Windows is small, and the set of people who deal with libXaw is small, and
the intersection of those two sets is tiny. (It also doesn't help that we've
sucked for years at handling patches by email for the unmaintained modules like
libXaw - we're trying to get better with gitlab merge requests now, but we're
still not great - unmaintained modules are still not well maintained.)
I was hoping one of our Windows folks would comment on whether or not that's the
right way to handle this, or if there's some Windows header to include instead.
But if no one pipes up soon, I'll likely just go ahead and push it and see if
anyone complains afterwards that it broke something.
-Alan Coopersmith- [email protected]
Oracle Solaris Engineering - https://blogs.oracle.com/alanc
On 03/ 4/19 06:54 AM, James Larrowe wrote:
Ping. Anything wrong with this? It's only defined in the plugin header files for
gcc.
On Thu, Feb 28, 2019 at 12:56 PM James R Larrowe <[email protected]
<mailto:[email protected]>> wrote:
Fix build with --enable-selective-werror.
Signed-off-by: James R Larrowe <[email protected]
<mailto:[email protected]>>
---
src/OS.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/OS.c b/src/OS.c
index 4c69005..cd0c517 100644
--- a/src/OS.c
+++ b/src/OS.c
@@ -37,6 +37,9 @@ _XawGetPageSize(void)
#endif
#ifdef HAVE_GETPAGESIZE
+# if defined(_WIN32)
+extern int getpagesize(void);
+# endif
if (pagesize == -1)
pagesize = getpagesize();
#endif
--
2.11.0
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
