Hi René,
The reasons I am renaming the files are to unify the naming convention of
certain files and to make them consistent across many DDXs.
Regarding the character spacing issue, it is pretty annoying to have tabs and
white spaces mixed up when working on the code.
Furthermore, I am trying to align the code with the X.Org coding guideline.
Speaking of working on the code, there will be a fix for xf86-video-trident
for TGUI family of devices eventually (I have not posted the patch yet), and I
am currently analyzing why Cirrus Logic Laguna based devices do not work on X
Server 1.19, unless acceleration is explicitly turned off.
While I will not explicitly commit to it at this point, I will likely
modernize the old, neglected DDXs when I have more time in the years ahead.
I am trying to clean up the code before that happens.
Regards,
Kevin Brace
Brace Computer Laboratory blog
https://bracecomputerlab.com
> Sent: Tuesday, February 26, 2019 at 11:08 AM
> From: "René Rebe" <[email protected]>
> To: "Kevin Brace" <[email protected]>
> Cc: [email protected]
> Subject: Re: [PATCH xf86-video-trident 0/3] Convert xp4_accel_exa.c to
> xp4_exa.c
>
> Hi,
> ed
> On 26 Feb 2019, at 00:41, Kevin Brace <[email protected]> wrote:
>
> > --
> > Kevin Brace (3):
> > Tab to spaces conversion for xp4_accel_exa.c
> > Fix indentation of xp4_accel_exa.c
> > Rename xp4_accel_exa.c to xp4_exa.c
> >
> > src/Makefile.am | 2 +-
> > src/{xp4_accel_exa.c => xp4_exa.c} | 208 ++++++++++++++++-------------
> > 2 files changed, 115 insertions(+), 95 deletions(-)
> > rename src/{xp4_accel_exa.c => xp4_exa.c} (58%)
>
>
> While I in general appreciate your work, I do not quite understand why you
> need
> to rename files and re-space files. IMHO this does not make maintaining and
> especially historical code comparison, re-diffing, cherry-picking and bug
> hunting
> easier, ..? :-/
>
> René
>
> --
> ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
> http://exactcode.com | http://exactscan.com | http://ocrkit.com |
> http://t2-project.org | http://rene.rebe.de
>
>
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
