Hi Hans,

On Fri, 21 Dec, 2018 at 11:21 AM, Hans de Goede <[email protected]> wrote:
KEY_KEYBOARD has an evdev-keycode value of 374 not 366. It seems that
with the original addition of the mapping the evdev-keycode value was
mistaken for the X scancode which is 8 higher then the evdev-keycode
since the X scancodes start at 8. What seems to have happened is that
the evdev-keycode was used instead of the X scancode and then 8 was
subtracted for the wrong "// #define KEY_KEYBOARD      366" comment.
Ups. Sorry for that. Your explanation seems very plausible.

This commit corrects the comment to say 374 and corrects the X
scancode being mapped to 382.
"#define KEY_KEYBOARD      0x176" is 374 indeed, so looks good to me. Thanks!

Reviewed-by: Christian Kellner <[email protected]>



_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to