Alexander Volkov <[email protected]> writes: This code should be fine, but it's hard to review because all of the old code has been moved around. Ideally, you'd create a pair of patches, the first of which does the major code motion of the old code without changing any functionality, and then a second patch which adds the fd passing bits. If you think you can manage that, I can review it more quickly.
> +#if (XCB_SHM_MAJOR_VERSION == 1 && XCB_SHM_MINOR_VERSION >= 2) || > XCB_SHM_MAJOR_VERSION > 1 I'd be fine with just requiring a newer version of the XCB bits instead of having these extra #if bits. -- -keith
signature.asc
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
