Peter Hutterer <[email protected]> writes: > From: Eric Anholt <[email protected]> > > The failing struct comes from the python test written by Michal Srb > <[email protected]>. > > v2: Use a drawable (root window) and gc, so that PolyLines hopefully > actually tries processing things. However, the request seems to > process successfully so the poll() just stalls out. However, this > does let us distinguish between detecting the bigrequests error > and not, at least. > v3: Clean up the description of what we expect the poll() call to do. > v4: change to use XISelectEvents > > Signed-off-by: Eric Anholt <[email protected]> > Signed-off-by: Peter Hutterer <[email protected]> > --- > Couldn't get v3 to crash here, even after changing to PolyRectangle. But I > found an easy to trigger test in XI2 - we know the server replies with > BadValue for a zero num_masks argument. So if we send a bigreq with a > num_masks 0 and a length 0, we can just check whether we get killed (good) > or a BadValue (bad). It doesn't test for specific memory overflows or > crashes, but based on the assumption that we shouldn't look at *any* BigReq > of size 0, this seems to be sufficient.
Your changes look good to me. Want to push?
signature.asc
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
