Peter Harris <[email protected]> writes: > On 2017-08-11 5:50 AM, Peter Hutterer wrote: >> On Tue, Aug 08, 2017 at 11:16:13AM -0400, Peter Harris wrote: >>> The epoll code depends on epoll_create1, not epoll_create. >>> >>> The trinary " ? 1 : false" is used because HAVE_EPOLL_CREATE1 is tested >>> with #if instead of #ifdef. >> >> might be worth using conf_data.set10(...) then? that should write out 0/1 >> correctly. > > ".set10" writes 1 or 0, whereas "? 1 : false" writes 1 or #undef, which > more closely matches what autoconf does. > > I'm fine with .set10 if you don't mind a little divergence. Or I could > change #if HAVE_EPOLL_CREATE1 to #ifdef HAVE_EPOLL_CREATE1 to match > (most of) the rest of the server instead, if you prefer.
I like that -- it's what I did to our other #ifs for meson.
signature.asc
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
