Am 29.10.2016 05:37, schrieb Rhys Kidd:
> XtRemoveEventHandler.c:458:3: warning: format '%d' expects a matching 'int' 
> argument [-Wformat=]
>    sprintf(ebuf, "ERROR: Error message handler was invoked %d times");
>    ^
> XtRemoveEventHandler.c:463:3: warning: format '%d' expects a matching 'int' 
> argument [-Wformat=]
>    sprintf(ebuf, "ERROR: Warning message handler was invoked %d times");
>    ^
> XtRemoveEventHandler.c:540:3: warning: format '%d' expects a matching 'int' 
> argument [-Wformat=]
>    sprintf(ebuf, "ERROR: Error message handler was invoked %d times");
>    ^
> XtRemoveEventHandler.c:545:3: warning: format '%d' expects a matching 'int' 
> argument [-Wformat=]
>    sprintf(ebuf, "ERROR: Warning message handler was invoked %d times");
>    ^
> 
> Signed-off-by: Rhys Kidd <[email protected]>
> ---
>  xts5/Xt9/XtRemoveEventHandler.m | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/xts5/Xt9/XtRemoveEventHandler.m b/xts5/Xt9/XtRemoveEventHandler.m
> index 1851ef9..6e6cbbe 100644
> --- a/xts5/Xt9/XtRemoveEventHandler.m
> +++ b/xts5/Xt9/XtRemoveEventHandler.m
> @@ -425,13 +425,13 @@ int invoked = 0;
>       XtAppMainLoop(app_ctext);
>       LKROF(pid2, AVSXTTIMEOUT-2);
>       tet_infoline("TEST: Error message was not emitted");
> -     if (avs_get_event(3) != 0) {
> -             sprintf(ebuf, "ERROR: Error message handler was invoked %d 
> times");
> +     if (invoked = avs_get_event(3) != 0) {
> +             sprintf(ebuf, "ERROR: Error message handler was invoked %d 
> times", invoked);
>               tet_infoline(ebuf);
>               tet_result(TET_FAIL);
>       }

IMHO this is to complicated. what is wrong with:

invoked = avs_get_event(3);
if (invoked != 0) {
                sprintf(ebuf, "ERROR: Error message handler was invoked %d 
times", invoked);
                tet_infoline(ebuf);
                tet_result(TET_FAIL);
 }



> -     if (avs_get_event(2) != 0) {
> -             sprintf(ebuf, "ERROR: Warning message handler was invoked %d 
> times");
> +     if (invoked = avs_get_event(2) != 0) {
> +             sprintf(ebuf, "ERROR: Warning message handler was invoked %d 
> times", invoked);
>               tet_infoline(ebuf);
>               tet_result(TET_FAIL);
>       }


btw: this is the same msg als with avs_get_event(3). I have no clue what the 
differenz is
     but maybe it should be reflected in the errmsg.

just my 2 cents,

re,
 wh


> @@ -491,13 +491,13 @@ int invoked = 0;
>               tet_result(TET_FAIL);
>       }
>       tet_infoline("TEST: Error message was not emitted");
> -     if (avs_get_event(3) != 0) {
> -             sprintf(ebuf, "ERROR: Error message handler was invoked %d 
> times");
> +     if (invoked = avs_get_event(3) != 0) {
> +             sprintf(ebuf, "ERROR: Error message handler was invoked %d 
> times", invoked);
>               tet_infoline(ebuf);
>               tet_result(TET_FAIL);
>       }
> -     if (avs_get_event(2) != 0) {
> -             sprintf(ebuf, "ERROR: Warning message handler was invoked %d 
> times");
> +     if (invoked = avs_get_event(2) != 0) {
> +             sprintf(ebuf, "ERROR: Warning message handler was invoked %d 
> times", invoked);
>               tet_infoline(ebuf);
>               tet_result(TET_FAIL);
>       }
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to