On Sun, 2016-05-08 at 09:19 +0100, Emil Velikov wrote: > From: Yury Gribov <[email protected]> > > This allow us to be good citizen by hiding the private symbols and > reducing the overall size of the binary. > > Note: _IceTransNoListen must be exported (albeit being a non-public > symbol) as explained in the comment just above it. > > Signed-off-by: Yury Gribov <[email protected]> > > v2: > - Add commit message. > - Reuse existing CFLAGS > - Add a beefy comment about the _IceTransNoListen export. > > Signed-off-by: Emil Velikov <[email protected]>
The only question I have remaining here is how many version numbers we should bump to reflect this change. I think I can be convinced that bumping the soname isn't wholly necessary since clients were already going off-label to get at this API in the first place, but it'd be nice to see at least the package major number bumped so it's extremely obvious where the break happened. Assuming we do that, series is: Reviewed-by: Adam Jackson <[email protected]> - ajax _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
