On 1 May 2016 at 21:24, Rémi Cardona <[email protected]> wrote: > Le 17/04/2016 à 18:24, Emil Velikov a écrit : >> The current lower/upper case mix of the xnf API feels quite strange: >> >> ati/amdgpu/intel/nouveau... ddx seems to explicitly use the lower case >> xnfalloc as does the xserver (with these two patches). At the same time >> both xserver and the drivers rely on the uppercase xnfprintf ones. >> >> Looks like nasty legacy ... if we only had someone brave enouch to unify >> the whole tree ;-) > > A job for coccinelle/spatch ? > Afaict one could do it with sed alone. There is the catch that I haven't checked out the whole xorg tree ;-)
Not to mention the implied 'step 2 removing the upper case version of the functions' (is this a wise idea?) meaning that we'll need a handful of compat-api.h updates throughout. And the follow up - "don't use/deprecate xnf.*printf", as most/all users of these know the exact max size of the output string (~20 iirc) and/or there is no need for va_list. All of which could be done as time permits of course . Emil P.S. We might want to apply the top two autogen.sh changes tree-wide as well ;-) _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
