Hello Olivier,
On 10.03.2016 09:11, Olivier Fourdan wrote:
Hi Michael,
[...]
Re-sending as this did not seem to get noticed much the first
time.
I am not doing a formal review of your patch as it's outside of my
area of competences, just a few comments, trying to help.
Thank you, help welcome.
I am not sure re-sending the patch as-is is the best course of action
here, usually simply replying the original message with a gentle
reminder suffices.
Reason being that the original patch (sent only 4 days ago) is still
accessible in patchwork and still marked as "New":
https://patchwork.freedesktop.org/patch/75985/
And the new here is also available:
https://patchwork.freedesktop.org/patch/76437/
So you should mark on of the two as superseded in patchwork. But,
yes, patches do take some time for review.
Right, I am still not too familiar with the patch process for X.Org.
How do I mark the re-sent one, which as you said does not apply cleanly,
as superseded?
Another problem is this patch here won't apply here due to formatting
issues apparently:
$ pwc git-am 76437 Applying patch #76437 using 'git am' Description:
Re-send: [PATCH] modesetting: allow switching from software to
hardware cursors. Applying: Re-send: [PATCH] modesetting: allow
switching from software to hardware cursors. fatal: corrupt patch at
line 8 Patch failed at 0001 Re-send: [PATCH] modesetting: allow
switching from software to hardware cursors.
See below. But the original patch (the first one) doesn't seem to
suffer from the same formatting issues though.
hw/xfree86/drivers/modesetting/drmmode_display.c | 47
++++++++++-------------- 1 file changed, 20 insertions(+), 27
deletions(-)
diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c
b/hw/xfree86/drivers/modesetting/drmmode_display.c index
0d34ca1..36c3093 100644 ---
a/hw/xfree86/drivers/modesetting/drmmode_display.c +++
b/hw/xfree86/drivers/modesetting/drmmode_display.c @@ -485,44
+485,36 @@ drmmode_set_cursor_position(xf86CrtcPtr crtc, int x, int
y) drmModeMoveCursor(drmmode->fd,
drmmode_crtc->mode_crtc->crtc_id, x, y); } -static void +static
Bool drmmode_set_cursor(xf86CrtcPtr crtc) {
drmmode_crtc_private_ptr drmmode_crtc = crtc->driver_private;
drmmode_ptr drmmode = drmmode_crtc->drmmode; uint32_t handle =
drmmode_crtc->cursor_bo->handle; modesettingPtr ms =
modesettingPTR(crtc->scrn); - static Bool use_set_cursor2 =
TRUE; int ret; - if (use_set_cursor2) {
That won't apply. There are several occurrences of the same issue in
the patch being resent, I think best would be to use git-send-email
to send patches instead of Thunderbird -as seen in the message
source- (or any other MUA for that matter) that can break the patch
formatting and confuse git.
Indeed, I sent the original with g-s-e and the re-send with Thunderbird.
Thanks again.
Regards,
Michael
HTH, Cheers, Olivier
--
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt
ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
