2015-12-08 16:55 GMT-02:00 Uli Schlachter <[email protected]>:
> Could you check xcb_get_extension_data(HostX.conn, &xcb_xkb_id)->present
> first?
> I don't know why XKB's UseExtension has a supported field, but without this
> suggested check, the XCB connection will just go in an error state if the
> XKB
> connection is not actually present.
>
Done here. Thanks!
> > + if (!controls_r) {
> > + EPHYR_LOG_ERROR("Couldn't get XKB keyboard controls.");
> > + return FALSE;
>
> For this one you check for errors, with the following ones you do not. Is
> there
> a reason for that?
>
Sincerely, there's not. I'm including the other checks as well. Thanks!
> Also, even though it will never matter much, could you first send all the
> requests and then get the replies?
>
I've reorganized the code to send all requests at beginning and process
the replies as they are needed. I'm submitting a v3 right now.
Thank you very much!
--
*Laércio de Sousa*
*Orientador de Informática*
*Escola Municipal "Professor Eulálio Gruppi"*
*Rua Ismael da Silva Mello, 559, Mogi Moderno*
*Mogi das Cruzes - SPCEP 08717-390*
Telefone: (11) 4726-8313
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
