Adam Jackson <[email protected]> writes:

> This tripped me up at first (here and elsewhere in the series), it
> looks weird to read an fd that isn't the one passed in as an argument. 

I fixed this one and the kdrive/linux APM one. The other patches either
already used the passed-in fd directly, or had some more complicated
structure involving additional layers of closures and callbacks.

Ignoring the efficiency issue, it seems clearer to handle data from the
active file descriptor instead of fetching the same value from some
random global.

-- 
-keith

Attachment: signature.asc
Description: PGP signature

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to