On 26/08/2015 16:24, Olivier Fourdan wrote:
The value of FD_SETSIZE for those targets in xserver's configure.ac:403
probably needs to be increased to match (See the comment on xserver
commit ed2c2a68)
Yeah, well, I changed that already to 512 in commit d206c240 for consistency
(in doubt, I tried to keep consistent).
Sorry, it seems I wasn't looking at the current git master. That's fine.
In that case, your patch has my Reviewed-by:
(The default value of FD_SETSIZE for those targets is only 64)
I'm somewhat sceptical that things work well with >64 clients on
those targets, but that's a different issue.
I tried to search for this on ze interweb and found a few references
(e.g. [1] [2]) that seem to indicate that, even if the default value
is 64, it's possible to increase that limit. But other than that,
I'll easily admit being quite clueless about Windows.
That said, if the value for FD_SETSIZE from Xpoll.h in x11proto is of
no use (if I understand correctly), we might as well remove it
completely from Xpoll.h. But I suspect we'd rather keep things
consistent, at least between the X server and x11proto, even if the X
server code doesn't seem to make use of XFD_SETSIZE when WIN32 is
set.
No idea. But I think this header might be used by X clients as well.
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
