On 25/02/15 06:41 PM, Tormod Volden wrote:
>> And then disable the DownloadFromScreen() implementation, or perhaps
>> even disable EXA altogether.
> If nobody can find the real problem that is maybe all that can be done.
The fix should be:

char *src = pExa->memoryBase + exaGetPixmapOffset(pSrc);

When I first saw exaGetPixmapFirstPixel() in savage and mga, I assumed
this was just a shorthand for the above. But evidently it's not. As for
other broken EXA drivers, I don't have hardware to test but some basic
suggestions are:

1. Use the above instead of pPix->devPrivate.ptr.
2. Make all hooks start by verifying that pSrc is non-NULL.
3. Remove UTS / DFS hooks unless they actually do a DRM blit.

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to