On 02/ 7/15 10:16 AM, Emil Velikov wrote:
On Saturday, 7 February 2015, Alan Coopersmith <[email protected]
<mailto:[email protected]>> wrote:
Reviewed-by: Alan Coopersmith <[email protected]>
Though I wonder if now you can drop the explicit #define _GNU_SOURCE in
linux_sysfs.c now that you moved the config.h up to the same spot, since
the AC_USE_SYSTEM_EXTENSIONS in configure.ac <http://configure.ac> should
#define _GNU_SOURCE in
config.h.
Thanks for the review Alan.
If you don't mind I'll do the removal as a follow up patch. Will give these
another 2 days and I'll resend the series with all the comments addressed +
correct prefix.
Sounds good to me. (And as for patch 4/4, I have no objections to it, I just
figured someone who actually builds on Linux and knows the difference between
__linux__ and linux #defines should review it instead of me.)
--
-Alan Coopersmith- [email protected]
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
