Adam Jackson <[email protected]> writes:
> static Bool exaFillRegionSolid(DrawablePtr pDrawable, RegionPtr pRegion,
> Pixel pixel, CARD32 planemask, CARD32 alu,
> - unsigned int clientClipType);
> + Bool clientClip);
Using clientClip as the name for a boolean seems likely to lead to
confusion with the usual usage of that name. Perhaps 'hasClientClip'?
> > void
> xnestDestroyClip(GCPtr pGC)
> {
> - xnestDestroyClipHelper(pGC);
> -
> + RegionDestroy(pGC->clientClip);
Need to check for NULL before calling RegionDestroy:
@@ -276,9 +276,11 @@ xnestChangeClip(GCPtr pGC, int type, void *pValue, int
nRects)
void
xnestDestroyClip(GCPtr pGC)
{
- RegionDestroy(pGC->clientClip);
- XSetClipMask(xnestDisplay, xnestGC(pGC), None);
- pGC->clientClip = NULL;
+ if (pGC->clientClip) {
+ RegionDestroy(pGC->clientClip);
+ XSetClipMask(xnestDisplay, xnestGC(pGC), None);
+ pGC->clientClip = NULL;
+ }
}
The rest of this patch has been
Reviewed-by: Keith Packard <[email protected]>
--
[email protected]
pgpOPkOW9l6cr.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
