On Tue, Jul 8, 2014 at 2:23 PM, Burton, Ross <[email protected]> wrote: > On 8 July 2014 22:14, Matt Turner <[email protected]> wrote: >> On Tue, Jul 8, 2014 at 2:07 PM, Ross Burton <[email protected]> wrote: >>> xshmfence is usable outside of DRI3, and is currently autodetected which >>> isn't >>> good for distributions where deterministic builds are aspired to. >> >> Forgot to reword. s/aspired to/desired/ > > Done. > >>> +AC_ARG_ENABLE(xshmfence, AS_HELP_STRING([--disable-xshmfence], >>> [Disable xshmfence (default: auto)]), [WANT_XSHMFENCE="$enableval"], >>> [WANT_XSHMFENCE="auto"]) >> >> None of the other variables are prefixed with WANT_. I'd drop that. > > There's already a variable called XSHMFENCE containing the pkgconfig > dependencies, and WANT_/HAVE_ make the logic obvious in my opinion.
Oh, looks like that should have been named LIBXSHMFENCE. _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
