Eric Anholt <[email protected]> writes: > Keith Packard <[email protected]> writes: > >> This just calls miPushPixels until glamor uses FBOs for bitmaps > > The only cases that PushPixels() is called that I can find: > > - miglblt.c > > We're doing hand-accelerated glyph blits, so that's gone. > > - miarc.c > > I tried a few likely x11perfs and nothing hit it. Eventually I came up with > on -wpcircle100 -rop GXnand, and this patch was 1.5% faster while > removing apparent rendering bugs. > > - midispur.c > > I don't think this is a thing we're worried about.
I've rewritten the glamor_push_pixels code to share the same programs as glamor_poly_glyph_blt, so at least the amount of 'complicated' code for push_pixels is minimized. The only reason to keep a glamor version will be when (if?) we have GPU-resident bitmaps and want to avoid all fallbacks. In that case, the PushPixels code will look a lot more like the core text code than the core glyph blt code. I'm just as happy to delete the rewritten push pixels code though; it's not much source, and as you say, offers little in the way of acceleration. -- [email protected]
pgp8D9A44bcFz.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
