This patch series is a very nice cleanup. I like the new way how this functions should be implemented, but the shader generator. Plain GLSL + predefined header are less confusing and more flexible imo.

We also have to figure out on which gl extension we want to rely on. eg I don't think we should fall back to fb because glsl130 + ARB_instanced_arrays aren't available.

Somehow I feel like you haven't seen my review mails on your first attempt of this series, have you?

Am 2014-03-19 06:09, schrieb Keith Packard:
This replaces all of the X core rendering code in glamor with shiny
new stuff. This is the second time around for this code, it now passes
the X test suite for Xlib chapter 9 (thanks to Eric's work making that
run under piglit). And, it also now runs correctly when debugging with
tiny FBOs tiling the pixmaps.

There are  two core X server bug fixes at the head of this list,
followed by some simple fixes to the core of glamor. Then a pile of
new rendering code, followed by the removal of some of the
old.

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to