On 25/02/2014 01:47, Eric Anholt wrote: > v2: Avoid making the Ximage for the screen that we'll never use, and > drive the screen pixmap creation for glamor ourselves. > > Signed-off-by: Eric Anholt <[email protected]> > Reviewed-by: Keith Packard <[email protected]> (v1)
It seems this needs some more #ifdef GLAMOR/#endif guards to compile successfully when ./configured --disable-glamor See http://tinderbox.x.org/builds/2014-03-07-0004/logs/xserver/#build Patch attached.
From 2f16a186a27ca9a88b72337ffacb86c8afb33803 Mon Sep 17 00:00:00 2001 From: Jon TURNEY <[email protected]> Date: Fri, 7 Mar 2014 14:53:07 +0000 Subject: [PATCH] Fix xephyr build in --disable-glamor case Fix xephyr build in --disable-glamor case, after commit 9fe052d90cca90fdf750d3a45b151be2ac7f0ebd "xephyr: Build support for rendering with glamor using a -glamor option." See http://tinderbox.x.org/builds/2014-03-07-0004/logs/xserver/#build Signed-off-by: Jon TURNEY <[email protected]> --- hw/kdrive/ephyr/hostx.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/kdrive/ephyr/hostx.c b/hw/kdrive/ephyr/hostx.c index 19c2ed2..859beca 100644 --- a/hw/kdrive/ephyr/hostx.c +++ b/hw/kdrive/ephyr/hostx.c @@ -309,9 +309,11 @@ hostx_init(void) | XCB_EVENT_MASK_STRUCTURE_NOTIFY; EPHYR_DBG("mark"); +#ifdef GLAMOR if (ephyr_glamor) HostX.conn = ephyr_glamor_connect(); else +#endif HostX.conn = xcb_connect(NULL, &HostX.screen); if (xcb_connection_has_error(HostX.conn)) { fprintf(stderr, "\nXephyr cannot open host display. Is DISPLAY set?\n"); @@ -322,11 +324,12 @@ hostx_init(void) HostX.winroot = xscreen->root; HostX.gc = xcb_generate_id(HostX.conn); HostX.depth = xscreen->root_depth; - if (ephyr_glamor) { +#ifdef GLAMOR + if (ephyr_glamor) HostX.visual = ephyr_glamor_get_visual(); - } else { + else +#endif HostX.visual = xcb_aux_find_visual_by_id(xscreen,xscreen->root_visual); - } xcb_create_gc(HostX.conn, HostX.gc, HostX.winroot, 0, NULL); cookie_WINDOW_STATE = xcb_intern_atom(HostX.conn, FALSE, @@ -760,6 +763,7 @@ hostx_paint_rect(KdScreenInfo *screen, EPHYR_DBG("painting in screen %d\n", scrpriv->mynum); +#ifdef GLAMOR if (ephyr_glamor) { BoxRec box; RegionRec region; @@ -774,6 +778,7 @@ hostx_paint_rect(KdScreenInfo *screen, RegionUninit(®ion); return; } +#endif /* * Copy the image data updated by the shadow layer -- 1.8.3.4
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
