On 01/29/14 01:14 PM, Keith Packard wrote:
  void
-NoticeF(const char *f, ...)
+VErrorF(const char *f, va_list args)
  {
-    /* XXX should Notices just be ignored if not using syslog? */
-    va_list args;
-    va_start(args, f);
  #ifdef USE_SYSLOG
      if (UseSyslog) {
        vsyslog(LOG_NOTICE, f, args);
@@ -160,6 +157,15 @@ NoticeF(const char *f, ...)
      fprintf(stderr, "%s notice: ", progname);
      vfprintf(stderr, f, args);
  #endif /* USE_SYSLOG */
+}
+
+void
+NoticeF(const char *f, ...)
+{
+    /* XXX should Notices just be ignored if not using syslog? */
+    va_list args;
+    va_start(args, f);
+    VErrorF(f, args);
      va_end(args);
  }

Shouldn't that have been done with ErrorF instead of NoticeF, to keep
them with the error prefix & syslog level?   Seems strange to have
VErrorF come through at a different level than ErrorF.


--
        -Alan Coopersmith-              alan.coopersm...@oracle.com
         Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to