The whole series LGTM. Reviewed-by: Zhigang Gong <[email protected]>
BTW, I'm more than happy to see glamor is going to be merged into Xserver eventually :).Thanks. There is still a separate glamor mail list and I remember there should be one patchset pending to be merged, the subject is "[Glamor] [PATCH v2 0/3] autoconf: configuration for egl, gbm and dri3 support" CC to the glamor mail list, just in case anybody is not aware of that the glamor is in transition to be part of xserver. Thanks, Zhigang Gong On Fri, Jan 10, 2014 at 9:26 AM, Eric Anholt <[email protected]> wrote: > Here's my first patch series for review on glamor -- mostly boring > stuff just trying to get things to a consistent style with the rest of > the server. The end result is a building module we can start doing > interesting things to, with no compiler warnings on my system. > > Note that x-indent.sh did horrible things to string literals, and > produced a line (present in two patches) that made git-send-email > choke. I just dropped the boring output of x-indent.sh patch > contents, and hacked out that line of patch 3. You can find the real > series up at git://people.freedesktop.org/~anholt/xserver on the > glamor-reformat branch. (once again, more things, some of them > unpolished, are also on the glamor-server branch). > > _______________________________________________ > [email protected]: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: http://lists.x.org/mailman/listinfo/xorg-devel _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
