On Fri, Jan 03, 2014 at 10:11:55AM +0000, Daniel Stone wrote: > Hi, > > On 3 January 2014 01:30, Peter Hutterer <[email protected]> wrote: > > -#if GET_ABI_MAJOR(ABI_XINPUT_VERSION) >= 19 > > -#if GET_ABI_MINOR(ABI_XINPUT_VERSION) >= 2 > > +#if GET_ABI_MAJOR(ABI_XINPUT_VERSION) > 19 > > +#define NO_DRIVER_SCALING 1 > > +#elif GET_ABI_MAJOR(ABI_XINPUT_VERSION) == 19 && > > GET_ABI_MINOR(ABI_XINPUT_VERSION) >= 2 > > /* as of 19.2, the server takes device resolution into account when scaling > > relative events from abs device, so we must not scale in synaptics. */ > > #define NO_DRIVER_SCALING 1 > > #endif > > -#endif > > Doesn't the minor check have to be done at runtime as well?
could do that but I'm not sure it's worth it. if the driver was built against 19.2 or later it won't load against anything earlier and distros can hopefully rebuild accordingly. you're right, this would've been a good addition when the change was introduced, but it's been a while now and I think distros have accommodated for it by now. Cheers, Peter _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
